Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avatar disabling when it is set to Default #34160

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Avatar disabling when it is set to Default #34160

wants to merge 2 commits into from
+11 −3

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Dec 10, 2024 •
edited by dougfabris
Loading

This PR introduces a new prop, profileAvatar, in the UserAvatarEditor component. The profileAvatar prop is passed from the AccountProfileForm component and indicates whether the value is undefined or a valid AvatarObject. This distinction determines whether the "Default Avatar" option should be disabled or enabled.

Proposed changes (including videos or screenshots)

Issue(s)

Closes #34159

Steps to test or reproduce

Further comments

@thepiyush-303 thepiyush-303 requested a review from a team as a code owner December 10, 2024 20:19
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d2bd80e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thepiyush-303
Copy link
Contributor Author

These changes in parent component will disable whole UserAvatarEditor also disables Upload option which is not desirable.
Screencast from 2024-12-11 12-02-26

@dougfabris
Copy link
Member

@thepiyush-303 I looked at it deeper and indeed my recommendation didn't work.
I send some changes, please take a look if it make sense too you.
Would be nice to add some tests on it as well, are you up to it?

@thepiyush-303
Copy link
Contributor Author

thepiyush-303 commented Dec 13, 2024 •
edited
Loading

The changes you provided seem valid at first glance, but they are not functioning as expected. When the form is submitted, the value is being lost, as demonstrated in this clip.

Screencast.from.2024-12-13.11-04-45.webm

Working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris Awaiting requested review from dougfabris

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Default Avatar in Account Profile Form is always enabled
2 participants
@thepiyush-303 @dougfabris